Add a favorite icon to the search screen#17140
Open
AlexViseven wants to merge 2 commits into
Open
Conversation
alperozturk96
force-pushed
the
feature/favorite_icon_in_search
branch
from
18b6e93 to
b4233d2
Compare
alperozturk96
requested changes
Jun 8, 2026
| } | ||
|
|
||
| private fun bindFavoriteIndicator(entry: SearchResultEntry) { | ||
| val file = storageManager.getFileByRemotePath(entry.remotePath()) |
Collaborator
There was a problem hiding this comment.
I can see multiple DB read for same path
val file = storageManager.getFileByRemotePath(entry.remotePath())
Please only read beginning of the fun bind(entry: SearchResultEntry) once then use it below for others.
alperozturk96
requested changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added displaying of favorite icon while searching files/folders
