feat: improve tablet and large-screen navigation layout#16764
Open
mykh-hailo wants to merge 7 commits intonextcloud:masterfrom
Open
feat: improve tablet and large-screen navigation layout#16764mykh-hailo wants to merge 7 commits intonextcloud:masterfrom
mykh-hailo wants to merge 7 commits intonextcloud:masterfrom
Conversation
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Contributor
Author
|
@alperozturk96 Could you please check my PR for the tablet view? |
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
cef7b13 to
a15915f
Compare
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adapts the main file browser and several activities for tablets and wide layouts (typically sw600dp / w600dp) by using a persistent navigation column next to content instead of relying only on the sliding DrawerLayout pattern used on phones.
Closes: #14871
Closes: #16141
DrawerActivity is updated so drawer behavior works when the root layout is not a DrawerLayout (e.g. ConstraintLayout with a fixed-width nav region). Alternative layouts under layout-sw600dp align Compose, Navigator, Contacts preferences, Synced folders, and Upload list with the same idea. files.xml is refactored to support the sidebar + content structure and to keep ViewBinding (FilesBinding / drawer_menu) consistent. TrashbinActivity and toolbar_standard are adjusted for the new structure. New sidebar.xml and resource tweaks (bools, dims) support the tablet configuration.
Technical notes
DrawerActivity: Centralizes “menu layout” handling; drawer toggle, ActionBarDrawerToggle, and related APIs run only when the root is aDrawerLayout; optional hamburger visibility when the layout does not use a sliding drawer.files.xml+sidebar.xmlstructure;FileDisplayActivityupdated as needed for binding / initialization.