Merged
Conversation
Fixes for Issue 287
Mostly removed no_superfluous_phpdoc_tags, phpdoc_trim and no_empty_phpdoc
…egration tests run.
Tests were expecting the directory to be samples/objectstore - I *think* because they take the service name, ("ObjectStore"), and lower-case it.
This eased debugging a lot.
…() in the one place we were using Guzzle's.
Guzzle 7 requires PHP 7.2.5, so we are doing the same here.
… with the recommended replacement. This will hopefully easy the adoption of php8. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…php8 Update phpunit and allow php8
Fix Call to undefined function GuzzleHttp\Psr7\modify_request()
allow uri-template 1.0 to be compatible with the latest Laravel
* fix tests for new Guzzle * unit tests workflow
…-opencloud#361) * change \GuzzleHttp\Promise\all to \GuzzleHttp\Promise\Utils::all * support old promises as well * run unit tests only on pull_request
* fix tests for new Guzzle * run object store and identity integration tests * use CamelCase directories in samples for docs
* format segment name, close php-opencloud#365 --------- Co-authored-by: Vlastimil Pečínka <vlastimil.pecinka@firma.seznam.cz>
Add integration workflows for services: - BlockStorage - Compute - Images - Networking
* add readthedocs.yaml * remove button * move to python 3
* fix php-opencloud#351 * fix documentation requirements, remove unused links in docs * add badges, remove old contacts from README.md
* clarify versioning * change documentation copyright
Author
|
https://github.com/nexcess/openstack/pull/21/files#diff-6c3f6ae2ffad621b061b3d1591159e32ff8ccdcf8cdfe81e1709c833b21392a9 https://github.com/nexcess/openstack/pull/21/files#diff-babe14547dbd0577849c6fd23247633652c5a6a970fd9141ade9b1866c0c2888R202 https://github.com/nexcess/openstack/pull/21/files#diff-babe14547dbd0577849c6fd23247633652c5a6a970fd9141ade9b1866c0c2888R27 |
davemednick
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.