DiffSync deprecation fix#281
Merged
Merged
Conversation
abates
requested review from
Kircheneer,
chadell and
glennmatthews
as code owners
glennmatthews
previously approved these changes
Sep 26, 2024
glennmatthews
left a comment
glennmatthews
left a comment
Collaborator
There was a problem hiding this comment.
Change looks good, just need to make black happy.
abates
force-pushed
the
fix-deprecation
branch
from
49d6831 to
9d4b3bf
Compare
Contributor
Author
Okay, I got black and flake8 fixed, not sure how to fix the pylint error, though. |
Collaborator
|
Looks like pylint worked correctly (but failed with a few specific issues) on rerun |
abates
force-pushed
the
fix-deprecation
branch
from
9d4b3bf to
e465626
Compare
glennmatthews
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280