Improve error handling in the kickstart script when fetching files.#22424
Draft
Ferroin wants to merge 1 commit into
Draft
Improve error handling in the kickstart script when fetching files.#22424Ferroin wants to merge 1 commit into
Ferroin wants to merge 1 commit into
Conversation
This adds code to differentiate between: - Failures to connect to the remote server - TLS errors - Inability to actually fetch the file due to a 4xx or 5xx error - Everything else That, in turn, lets us give more accurate error information when we fail to download a file. This also adds support for systems with GNU wget2 installed that do not include a `wget` compatibility link or a copy of `curl` (these systems should be rare, but a number of distros we support do technically allow for such a setup).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This adds code to differentiate between:
That, in turn, lets us give more accurate error information when we fail to download a file.
This also adds support for systems with GNU wget2 installed that do not include a
wgetcompatibility link or a copy ofcurl(these systems should be rare, but a number of distros we support do technically allow for such a setup).Test Plan
Requires manual testing to verify that everything still works.
Additional Information
Functionally equivalent to #22422, just for the kickstart script instead of the updater.
Summary by cubic
Improves the kickstart script’s download logic by classifying failures (connection, TLS, HTTP) and showing clear, specific messages. Adds support for systems that only have
wget2, and hardens GitHub/package repo checks.Bug Fixes
New Features
wget2ifwgetis missing; keeps BusyBoxwgethandling.Written for commit cba45ff. Summary will update on new commits.