Skip to content

chore: fix README transaction builder example#660

Merged
quake merged 2 commits into
nervosnetwork:masterfrom
blckngm:fix-readme-builder-example
Aug 1, 2023
Merged

chore: fix README transaction builder example#660
quake merged 2 commits into
nervosnetwork:masterfrom
blckngm:fix-readme-builder-example

Conversation

@blckngm
Copy link
Copy Markdown
Collaborator

@blckngm blckngm commented Aug 1, 2023

Close #659.

(Targets master because that's the default branch and where people are more likely to see the README.)

@quake
Copy link
Copy Markdown
Member

quake commented Aug 1, 2023

@blckngm there is a CI error, could you please help to check?

@blckngm
Copy link
Copy Markdown
Collaborator Author

blckngm commented Aug 1, 2023

I've cherry-picked the fix from develop.

@quake quake merged commit d05f5e6 into nervosnetwork:master Aug 1, 2023
@blckngm blckngm deleted the fix-readme-builder-example branch August 1, 2023 14:50
@doitian
Copy link
Copy Markdown
Member

doitian commented Aug 2, 2023

Better adding a test case to test the examples in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README examples are deprecated

3 participants