Skip to content

Conversation

@rtoijala
Copy link

When adding a random album, the album artist intuitively should
be the same for all added songs. Currently, this is not so,
so when adding e.g. 'Greatest Hits' you can get many different albums.

Fix this by randomly selecting one album artist whose songs to add.

Fixes Github issue #159.

I'm not quite sure how to handle albums with many album artists, so I've
ignored them for now. This is at least better than nothing.

When adding a random album, the album artist intuitively should
be the same for all added songs. Currently, this is not so,
so when adding e.g. 'Greates Hits' you can get many different albums.

Fix this by randomly selecting one album artist whose songs to add.

Fixes Github issue #159.
@larson-carter
Copy link
Collaborator

When adding a random album, the album artist intuitively should
be the same for all added songs. Currently, this is not so,
so when adding e.g. 'Greatest Hits' you can get many different albums.

Fix this by randomly selecting one album artist whose songs to add.

Fixes Github issue #159.

I'm not quite sure how to handle albums with many album artists, so I've
ignored them for now. This is at least better than nothing.

@rtoijala Very good work. I'm just not going to merge this into our branch until we can figure out a way to handle albums with many album artists as you have mentioned above. Once we get that figured out we can test and proceed from there.

@larson-carter
Copy link
Collaborator

I've now decided I'm going to close this PR due to inactivity from Author. Once it is reopened we can work on getting Many Album and artist figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants