fix: nativewind theme functions on web - #1346
Open
sjwall wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Hey @marklawlor are you able to look at reviewing this please? |
Member
|
I'll play around with this over the weekend and follow up |
Contributor
Author
|
How did you get on with the change? |
Member
|
I'll take a look at this PR tomorrow |
Member
|
@marklawlor mind taking a look at this? |
Member
|
Thanks for the contribution! The If you're still interested, retarget this to the |
danstepanov
added
question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1160 and #1179
The
platformSelectfunction when running on web is using the native version whenNATIVEWIND_OSis set toweb.Using the #1160 example repo
Putting a
console.log(process.env.NATIVEWIND_OS)in tailwind config is always printingundefinedwhen building for web.But logging to a file instead results in
webbeing printed:I tried adding test cases but couldn't get the
NATIVEWIND_OSenvironment variable to be set to undefined in the test case.