qemu qmp: Use SystemWakeUp only when vm is suspended #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-otter
approved these changes
May 9, 2021
Member
h-otter
left a comment
h-otter
left a comment
There was a problem hiding this comment.
多分ubuntu 20.04じゃないと動かなくなる変更だと思うんでドキュメントを更新しといてほしいかも？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / 変更点
Why / 変更した理由
system_wakeupは suspend 状態の VM を再開するために使用するものであったが、以前の QEMU では suspend でないVMに対して実行したときにもエラーが生じず無視されるだけであったcontだけで十分であるため、そのように修正How (Optional) / 概要
How affect / 影響範囲