Skip to content

[WIP] Implement virtualmachine's shutdown operation #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kyontan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Implement virtualmachine's shutdown operation #124

kyontan wants to merge 2 commits into from

Conversation

@kyontan
Copy link
Member

@kyontan kyontan commented Feb 19, 2019 •
edited
Loading

What / 変更点

  • agent と api の ShutdownVirtualMachine を実装した
  • func (q Qemu) HardShutdown() error の実装がおそらくおかしかったため修正した
  • TODO: シャットダウンリクエストを同期的に行う
    • QEMU がシャットダウンステータスになるまで待つ
    • タイムアウトは60秒で固定
      • タイムアウトした場合はその時点での QEMU のステータスをデータストアに書き込む

Why / 変更した理由

未実装だったため

How (Optional) / 概要

How affect / 影響範囲

特になし

シャットダウンが終了することは保証しないため、これに依存するDAGで起動等をすると失敗することは考えられる (新規実装部分であるため、既存影響はない)

@kyontan kyontan self-assigned this Feb 19, 2019
@kyontan kyontan requested a review from h-otter February 19, 2019 19:29
h-otter
h-otter reviewed Feb 20, 2019
View reviewed changes
@h-otter
Copy link
Member

h-otter commented Feb 24, 2019

実際シャットダウンしたか確認するべきだと思うけど、libvirtみたいにタイムアウトを待つ必要がありそうだしどうしようか…

@kyontan kyontan changed the title Implement virtualmachine's shutdown operation [WIP] Implement virtualmachine's shutdown operation Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-otter h-otter h-otter left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kyontan kyontan

Labels

component:n0cli type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kyontan @h-otter