This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Dev/metrics #59
Merged
Dev/metrics #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
It would be nice to explain in what case PARTIAL can be returned (looks like "a subset of memory instruments are enabled in Performance schema").
Member
|
Nice, couple of small clean up things and good to go. One related, but not stopping comment - it seems like the "yes/no/partial" enablement checking could be extracted out to a function, and could be generally useful in the future for other wait classes etc. too perhaps. |
Contributor
Author
|
Fixed the year in the copyright headers and adding description of what PARTIAL means for the Enabled column. I like the idea of a function to calculate the yes/no/partial enablement, but will leave that for later. |
MarkLeith
added a commit
that referenced
this pull request
Jun 3, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two views: metrics and metrics_56. The difference betweem the metrics and the metrics_56 views are whether the global status is taken from performance_schema.global_status instead of
from the Information Schema.Use the metrics view if the MySQL version is 5.7.6 or later and show_compatibility_56 = OFF. Otherwise use metrics_56.
See also https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_show_compatibility_56
The views provide a union of the following information: