Merged
Conversation
Member
BenjaminAbt
commented
Jan 14, 2025
BenjaminAbt
commented
- fixes Remove Fluent Assertions #52
gfoidl
approved these changes
Jan 14, 2025
Contributor
gfoidl
left a comment
gfoidl
left a comment
There was a problem hiding this comment.
Unnecessary changes in the csprojs. Otherwise LGTM.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> |
Member
Author
There was a problem hiding this comment.
I will transfer the Common Definitions like Roslyn etc into the Build Props... then I have to separate them here anyway.
Contributor
There was a problem hiding this comment.
Ah, OK. But a separate PR for this would be welcomed 😉 That change is unrelated to "remove fluent assertions".
Comment on lines
+8
to
+9
| <PackageReference Include="Microsoft.Extensions.Caching.Memory" /> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> |
Contributor
There was a problem hiding this comment.
Undo this change and move it back to where it was.
Member
Author
There was a problem hiding this comment.
Same reason like above
Comment on lines
8
to
+9
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> | ||
| </ItemGroup> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.