Skip to content

Conversation

@bakajikara
Copy link
Contributor

@bakajikara bakajikara commented Nov 5, 2025

(cherry picked from commit 3749ef0)

Resolves: #19859
Resolves: #24779

This PR re-enables the low pass filter, which was disabled in #10731 (presumably to fix other issues).
This PR is a rebase of the closed PR #16448, originally authored by @handrok.

Regarding #19859 (comment):

When I tested #16448 there was a problem with Piano: on high dynamics (ff, fff) the tone didn't get any brighter as in MS3 (low pass filter didn't react on dynamic changes) @RomanPudashkin says that PR should be reworked (rebase is not enough)

I suspect the issue at that time might not have been the filter itself, but rather that the appropriate samples were not being used for different dynamics.

I believe this sample selection issue was resolved between v4.3 and v4.4. While I haven't pinpointed the exact commit, I can clearly hear the difference, and the v4.4.0 release notes state: "Dynamics now use optimal playback parameters (varies depending on sound technology) for more realistic playback," which seems relevant.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

3 participants