Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 3749ef0)
Resolves: #19859
Resolves: #24779
This PR re-enables the low pass filter, which was disabled in #10731 (presumably to fix other issues).
This PR is a rebase of the closed PR #16448, originally authored by @handrok.
Regarding #19859 (comment):
I suspect the issue at that time might not have been the filter itself, but rather that the appropriate samples were not being used for different dynamics.
I believe this sample selection issue was resolved between v4.3 and v4.4. While I haven't pinpointed the exact commit, I can clearly hear the difference, and the v4.4.0 release notes state: "Dynamics now use optimal playback parameters (varies depending on sound technology) for more realistic playback," which seems relevant.