Update top_200_tags.json - remove "instrumental" keyword - #26
Closed
mattjamo wants to merge 1 commit into
Closed
Conversation
removing "instrument" keyword
Collaborator
|
Thx, we will update the naming of the output file. It would fix the problem, no need to remove "instrument" keyword in top_200_tags.json . |
Author
|
Np, sounds good! Yeah, I thought implementing a fix myself would likely end up not being the preferred solution so went with the short term quick fix just to highlight the issue. |
Author
|
closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"instrumental" is used to as a keyword when recombining audio files at the end of stage 2. If it's added to the genre configuration file vocal_output is never created as all files contain the keyword causing the application to crash. Removing "instrument" keyword from tags for to prevent wide use.