Further split GotaTun apart from WireGuardGo#10311
Conversation
rablador
left a comment
There was a problem hiding this comment.
@rablador partially reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).
ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 101 at r1 (raw file):
} #else let wgImpl = WireGuardGoTunnelImplementation()
We should turn these three lines into a setup method so that it's consistent between call sites for wg impl.
6db1db3 to
3a7a3ac
Compare
pinkisemils
left a comment
There was a problem hiding this comment.
@pinkisemils made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on rablador).
ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 101 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
We should turn these three lines into a setup method so that it's consistent between call sites for wg impl.
Done.
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved.
3a7a3ac to
4fc57da
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
4fc57da to
9149438
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
9149438 to
9fcd3e1
Compare
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
I was not happy with how intertwined the previous GotaTun introduction is. This addresses that.
This change is