Skip to content

Further split GotaTun apart from WireGuardGo#10311

Open
pinkisemils wants to merge 1 commit into
mainfrom
ios-gotatun-switching-improvement
Open

Further split GotaTun apart from WireGuardGo#10311
pinkisemils wants to merge 1 commit into
mainfrom
ios-gotatun-switching-improvement

Conversation

@pinkisemils
Copy link
Copy Markdown
Collaborator

@pinkisemils pinkisemils commented Apr 27, 2026

I was not happy with how intertwined the previous GotaTun introduction is. This addresses that.


This change is Reviewable

@pinkisemils pinkisemils added the iOS Issues related to iOS label Apr 27, 2026
Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador partially reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pinkisemils).


ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 101 at r1 (raw file):

            }
        #else
            let wgImpl = WireGuardGoTunnelImplementation()

We should turn these three lines into a setup method so that it's consistent between call sites for wg impl.

@pinkisemils pinkisemils force-pushed the ios-gotatun-switching-improvement branch from 6db1db3 to 3a7a3ac Compare April 29, 2026 01:58
Copy link
Copy Markdown
Collaborator Author

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinkisemils made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on rablador).


ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 101 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

We should turn these three lines into a setup method so that it's consistent between call sites for wg impl.

Done.

Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@pinkisemils pinkisemils force-pushed the ios-gotatun-switching-improvement branch from 3a7a3ac to 4fc57da Compare April 29, 2026 10:48
Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@pinkisemils pinkisemils force-pushed the ios-gotatun-switching-improvement branch from 4fc57da to 9149438 Compare April 30, 2026 14:36
Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@pinkisemils pinkisemils force-pushed the ios-gotatun-switching-improvement branch from 9149438 to 9fcd3e1 Compare May 4, 2026 08:59
Copy link
Copy Markdown
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rablador reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Issues related to iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants