Repository navigation
[context menu] Keep Shift+Tab inside the open menu - #6072
Open
rohits2501 wants to merge 2 commits into
Open
rohits2501 wants to merge 2 commits into
rohits2501 wants to merge 2 commits into
Conversation
Shift+Tab closed a root context menu while Tab left it open.
rohits2501
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
October 22, 2026 16:19
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 4m 01s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@atomiks Please review when you get some time. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6063.
Tab leaves a context menu open. Shift+Tab closed it and moved focus back to the trigger.
After this change, Shift+Tab stays inside the open context menu, and focus stays on the menu. A submenu still closes on Shift+Tab and returns focus to its parent item.
A regular Menu has the same split: Tab stays inside, and Shift+Tab closes. Existing menu tests cover that close, so this change leaves Menu as it is.