[popups] Enable scroll lock on touch when modal #3100
+33
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
component: select
commit: |
Bundle size reportℹ️ Using snapshot from parent commit 6cc460b (fallback from merge base 3c18761).
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <cc.glows@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3098
Since
touchmoveis used, swiping still allows swipe-outside-to-dismiss to work, so the end result is mostly identical except with a slightly increased dead zone where scroll doesn't happen.This enables use cases like a popover that covers the whole screen (to use the anchoring behavior over
Dialog) where the background scroll remains locked