Add DolphinDB VSCode Extension for SQLTools#1435
Closed
ffliu29 wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Thank you for your interest in contributing. However, new drivers need to be standalone extensions with their own repo, and published on Marketplace under your own publisher id. It sounds like your driver will require the SQLTools extension to be migrated to NodeJS 22. In #1419 we recently moved to version 20 but we haven't yet released this. Are you willing to prepare a PR that only updates to version 22? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the DolphinDB VSCode Extension for SQLTools, enabling support for connecting to and interacting with the DolphinDB database through SQLTools. As part of this implementation, a new package, driver.dolphindb, has been added to the packages directory.
We have developed this extension to integrate DolphinDB with SQLTools. However, the project requires a Node.js v22 environment due to the use of the --experimental-transform-types compilation option, which is not supported in Node.js v20 (the current version used in the dev branch).
If merging this pull request into the main dev branch is not feasible due to the Node.js versioning conflict, we kindly request testing the extension independently in a Node.js v22 environment. Alternatively, would it be possible to create an official repository for the DolphinDB VSCode Extension for SQLTools? This would ensure the extension remains an official addition to SQLTools while being maintained independently.
Thank you for your time and consideration. We look forward to contributing to the SQLTools ecosystem!