added test changeSimpleToolColor#18
Merged
Merged
Conversation
added 3 commits
July 11, 2019 16:16
# Conflicts: # src/main/java/com/pdffiller/element/DocumentElements.java # src/main/java/com/pdffiller/element/ElementParameterOnToolbar.java
msulaev
reviewed
Jul 11, 2019
| editorStep.addSimpleTool("Cross", "cross1", grid); | ||
| editorStep.selectColorOnToolbar("Red"); | ||
| cssAttribute(editorStep.getElementColor("checkmark"), "Red"); | ||
| } |
Owner
There was a problem hiding this comment.
Вынести в отдельный класс(?) засунь часть методов в фикстуру.
Где ассерт?
Имя теста должно отображать проверку: shouldCanChangeSmth
Owner
There was a problem hiding this comment.
используй имплементацию cssAttribute с матчером is(Color.Red)\
msulaev
reviewed
Jul 11, 2019
msulaev
reviewed
Jul 11, 2019
added 2 commits
July 11, 2019 19:23
msulaev
reviewed
Jul 15, 2019
| documentGridForField = new DocumentGridForField(); | ||
| } | ||
|
|
||
| public enum Color { |
|
|
||
| import java.util.Optional; | ||
|
|
||
| public class MyCustomExt implements TestWatcher |
msulaev
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.