jimsh: persist history on Windows and add --interactive mode by Copilot · Pull Request #372 · msteveb/jimtcl

Copilot · 2026-05-07T10:41:06Z

Review new PR comments and identify required documentation changes
Inspect latest workflow runs and failure logs for this branch
Check current jim_tcl.txt content around "JIMSH COMMAND INTERPRETER"
Add missing Changes since 0.83 entry for jimsh --interactive
Validate documentation-only diff (no build required)
Run final parallel validation and reply to each new comment

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/491f3d70-abfd-4fa9-9096-031a7f803ce6 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

msteveb

Once you have added the --interactive flag to jimsh, the tests can be added to tests/jimsh.test

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/824500e5-facc-4ff2-8a1b-2b23a5dffb1b Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot · 2026-05-07T11:18:35Z

Once you have added the --interactive flag to jimsh, the tests can be added to tests/jimsh.test

Implemented in bea8aa1. Added --interactive support in jimsh and moved the new fallback tests to tests/jimsh.test.

msteveb · 2026-05-07T11:29:26Z

+	exec [info nameofexecutable] --interactive << "expr {2 + 3}\nexit\n"
+} -match glob -result {Welcome to Jim version*5*}
+
+test jimsh-1.10 {jimsh --interactive history fallback to USERPROFILE} -body {


bootstrap jimsh won't have history support. So at the top of this file add 'constraint cmd history' and require that constraint for test jimsh-1.10

Done in efb3097. I added constraint cmd history at the top of tests/jimsh.test and required -constraints history for jimsh-1.10.

msteveb

Small changes needed

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/ce0b36fd-74e5-4906-8180-d548d67c8c13 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot · 2026-05-07T11:49:22Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.google.com
- Triggering command: /home/REDACTED/work/jimtcl/jimtcl/jimsh /home/REDACTED/work/jimtcl/jimtcl/jimsh /home/REDACTED/work/jimtcl/jimtcl/tests/runall.tcl (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

msteveb

This is almost good enough. But the new --interactive flag needs to be documented in jim_tcl.txt

Add it in the SYNOPSIS (as jimsh [--interactive] [|-]
And also add it in the section "JIMSH COMMAND INTERPRETER"
And since this is new in this version, add it in the section "Changes since 0.83"

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/625b6f56-5e72-49bc-822e-c5a7dc0eeb45 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot · 2026-05-07T12:03:42Z

This is almost good enough. But the new --interactive flag needs to be documented in jim_tcl.txt

Add it in the SYNOPSIS (as jimsh [--interactive] [|-]...

Updated in dc2f325. I added --interactive to the SYNOPSIS as jimsh [--interactive] [<scriptfile>|-] in jim_tcl.txt.

Screenshot: N/A (documentation-only change).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.google.com
- Triggering command: /home/REDACTED/work/jimtcl/jimtcl/jimsh /home/REDACTED/work/jimtcl/jimtcl/jimsh /home/REDACTED/work/jimtcl/jimtcl/tests/runall.tcl it /usr/libexec/gcc--64 -qui�� -imultiarch x86_64-linux-gnu/tmp/ccKt0Naa.s /opt/pipx_bin/as -quiet -dumpbase conftest__.c as --64�� -o /tmp/ccB9DuPP.o tnet/tools/cc -fstack-protectoas -Wformat -Wformat-securit. as (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

msteveb

There are still two changes that need to be made in the documentation

…32b-4c70-80c2-ed90caf2bd0d Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

msteveb

There is still one remaining action item

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/0fc9a6b4-ad6a-400c-ae92-a684ddbca93e Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot · 2026-05-07T12:21:31Z

There is still one remaining action item

Addressed in 9d0b0a7 with the remaining documentation update in jim_tcl.txt (added jimsh --interactive to the Changes since 0.83 list).
Screenshot: N/A (documentation-only change).

Initial plan

ba0b525

Copilot AI assigned Copilot and msteveb May 7, 2026

Copilot started work on behalf of msteveb May 7, 2026 10:41 View session

Copilot AI linked an issue May 7, 2026 that may be closed by this pull request

jimsh on windows doesn't save history #371

Open

Copilot AI and others added 4 commits May 7, 2026 10:44

fix: use Windows home fallbacks for jimsh history

3ba7b98

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/491f3d70-abfd-4fa9-9096-031a7f803ce6 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

chore: refine Windows fallback logic and test naming

90d08aa

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/491f3d70-abfd-4fa9-9096-031a7f803ce6 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

chore: address validation nits for history fallback

646377b

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/491f3d70-abfd-4fa9-9096-031a7f803ce6 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

chore: finalize fallback length and env restore cleanup

6840c69

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/491f3d70-abfd-4fa9-9096-031a7f803ce6 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix jimsh on Windows to save command history~~ jimsh: persist history on Windows when HOME is unset May 7, 2026

Copilot AI requested a review from msteveb May 7, 2026 10:49

Copilot finished work on behalf of msteveb May 7, 2026 10:49

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread tests/interactive.test Outdated

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jim-interactive.c Outdated

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jim_tcl.txt Outdated

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jim_tcl.txt Outdated

msteveb requested changes May 7, 2026

View reviewed changes

Copilot started work on behalf of msteveb May 7, 2026 11:15 View session

feat: add jimsh --interactive and move history fallback tests

bea8aa1

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/824500e5-facc-4ff2-8a1b-2b23a5dffb1b Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot AI changed the title ~~jimsh: persist history on Windows when HOME is unset~~ jimsh: persist history on Windows and add --interactive mode May 7, 2026

Copilot finished work on behalf of msteveb May 7, 2026 11:19

Copilot AI requested a review from msteveb May 7, 2026 11:20

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread tests/jimsh.test Outdated

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jim-interactive.c Outdated

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jimsh.c Outdated

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jimsh.c Outdated

msteveb requested changes May 7, 2026

View reviewed changes

Copilot started work on behalf of msteveb May 7, 2026 11:44 View session

fix: apply requested review tweaks for interactive/history tests

efb3097

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/ce0b36fd-74e5-4906-8180-d548d67c8c13 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot finished work on behalf of msteveb May 7, 2026 11:49

Copilot AI requested a review from msteveb May 7, 2026 11:49

msteveb requested changes May 7, 2026

View reviewed changes

Copilot started work on behalf of msteveb May 7, 2026 11:59 View session

docs: add --interactive to jimsh synopsis

dc2f325

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/625b6f56-5e72-49bc-822e-c5a7dc0eeb45 Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot finished work on behalf of msteveb May 7, 2026 12:05

Copilot AI requested a review from msteveb May 7, 2026 12:05

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jim_tcl.txt

msteveb reviewed May 7, 2026

View reviewed changes

Comment thread jim_tcl.txt

msteveb requested changes May 7, 2026

View reviewed changes

Copilot started work on behalf of msteveb May 7, 2026 12:10 View session

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/10e5ef81-a…

ac29c09

…32b-4c70-80c2-ed90caf2bd0d Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot finished work on behalf of msteveb May 7, 2026 12:13

Copilot AI requested a review from msteveb May 7, 2026 12:13

msteveb requested changes May 7, 2026

View reviewed changes

Copilot started work on behalf of msteveb May 7, 2026 12:19 View session

docs: add jimsh --interactive to recent changes list

9d0b0a7

Agent-Logs-Url: https://github.com/msteveb/jimtcl/sessions/0fc9a6b4-ad6a-400c-ae92-a684ddbca93e Co-authored-by: msteveb <188705+msteveb@users.noreply.github.com>

Copilot finished work on behalf of msteveb May 7, 2026 12:22

Copilot AI requested a review from msteveb May 7, 2026 12:22

msteveb approved these changes May 7, 2026

View reviewed changes

msteveb marked this pull request as ready for review May 7, 2026 12:26

Conversation

Copilot AI commented May 7, 2026 • edited by msteveb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msteveb left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

msteveb May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msteveb left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 7, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

msteveb left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

msteveb left a comment

Choose a reason for hiding this comment

Uh oh!

msteveb left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 7, 2026 •

edited by msteveb

Loading

Copilot AI commented May 7, 2026 •

edited

Loading