fix: regression in docker file according to best practices

Tobi Schäfer · msokk · commit bad1a6d3cb34 · 2019-03-07T13:56:29.000+02:00
see https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run
diff --git a/Dockerfile b/Dockerfile
@@ -18,36 +18,44 @@ COPY .fonts.conf /root/.fonts.conf
 
 # Install the packages needed to run Electron
 RUN sed -i 's/main/main contrib/g' /etc/apt/sources.list
-RUN apt-get -y update
-RUN apt-get -y upgrade
-RUN apt-get install -y unzip xvfb libgtk2.0-0 ttf-mscorefonts-installer libnotify4 libgconf2-4 libxss1 libnss3 dbus-x11
+RUN apt-get update && apt-get upgrade -y && apt-get install -y \
+	unzip \
+	xvfb \
+	libgtk2.0-0 \
+	ttf-mscorefonts-installer \
+	libnotify4 \
+	libgconf2-4 \
+	libxss1 \
+	libnss3 \
+	dbus-x11 \
+	&& rm -rf /var/lib/apt/lists/*
 
 # As the inline fonts should not change much put them before the app
 COPY fonts/* /usr/share/fonts/truetype/
 
 # Install NodeJS
 RUN curl -sSL http://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -
 RUN echo "deb http://deb.nodesource.com/node_10.x jessie main" > /etc/apt/sources.list.d/nodesource.list
-RUN apt-get -y update
-RUN apt-get -y install nodejs
+RUN apt-get update && apt-get install -y \
+	nodejs \
+	&& rm -rf /var/lib/apt/lists/* \
+	&& rm -f /etc/apt/sources.list.d/nodesource.list
 
 # Install dependencies
 COPY package.json /app/package.json
-RUN sed -i '/\"electron\"\:/d' ./package.json
-RUN npm install --production --no-optional
+RUN sed -i '/\"electron\"\:/d' ./package.json \
+	&& npm install --production --no-optional
 
 # Install Electron
 # You can define a different Electron version on build using the `--build-args electron_version=x.y.z` argument
 ARG electron_version=4.0.6
-RUN wget "https://github.com/atom/electron/releases/download/v${electron_version}/electron-v${electron_version}-linux-x64.zip" -O electron.zip
-RUN unzip electron.zip
-RUN rm electron.zip
+RUN wget "https://github.com/atom/electron/releases/download/v${electron_version}/electron-v${electron_version}-linux-x64.zip" -O electron.zip \
+	&& unzip electron.zip \
+	&& rm electron.zip
 
 # Clean up
-RUN apt-get remove -y unzip nodejs
-RUN apt-get clean
-RUN rm -rf /var/lib/apt/lists/*
-RUN rm -f /etc/apt/sources.list.d/nodesource.list
+RUN apt-get remove -y unzip nodejs \
+	&& apt-get clean
 
 COPY . /app
 
