Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

[WIP] Add SymmetryRMSDFeaturizer#808

Open
mpharrigan wants to merge 9 commits into
msmbuilder:masterfrom
mpharrigan:symrmsd
Open

[WIP] Add SymmetryRMSDFeaturizer#808
mpharrigan wants to merge 9 commits into
msmbuilder:masterfrom
mpharrigan:symrmsd

Conversation

@mpharrigan
Copy link
Copy Markdown
Member

@mpharrigan mpharrigan commented May 10, 2016

  • Implement feature / fix bug
  • Add tests
  • Update changelog

For homo-multi-mers, there's rotational or permutational symmetry. This featurizer takes the minimum distance from a defined set of atom index permutations.

@mpharrigan
Copy link
Copy Markdown
Member Author

I also want to start splitting up featurizer.py--which is huge--into files grouped by theme

@brookehus
Copy link
Copy Markdown
Member

Maybe we should iron out #798 before we split up featurizer.py

@mpharrigan
Copy link
Copy Markdown
Member Author

This just splits out the rmsd ones. We can do it bit by bit

@mpharrigan
Copy link
Copy Markdown
Member Author

Realized I'm going to have to do this in libdistance so it works with clustering

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants