Revert "backlight: lm3630a: Turn off both led strings when display is blank"

z3ntu · z3ntu · commit 6c0e7097c41f · 2024-01-09T17:59:25.000+01:00
Appears to turn off the backlight on both oneplus-bacon and lg-hammerhead whenever the backlight brightness is changed. Could be connected to that Linux actually doesn't know the panel and backlight are connected, so maybe that's why it thinks it should blank it. Let's investigate later! This reverts commit ae9c480.
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
@@ -202,9 +202,7 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
 	usleep_range(1000, 2000);
 	/* minimum brightness is 0x04 */
 	ret = lm3630a_write(pchip, REG_BRT_A, bl->props.brightness);
-
-	if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))
-		/* turn the string off  */
+	if (bl->props.brightness < 0x4)
 		ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0);
 	else
 		ret |= lm3630a_update(pchip, REG_CTRL,
@@ -279,9 +277,7 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
 	usleep_range(1000, 2000);
 	/* minimum brightness is 0x04 */
 	ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness);
-
-	if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))
-		/* turn the string off  */
+	if (bl->props.brightness < 0x4)
 		ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDB_ENABLE, 0);
 	else
 		ret |= lm3630a_update(pchip, REG_CTRL,
