Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msgspec.toml.decode(b"name = '\xff'")currently raises a bareUnicodeDecodeError. Applications catchingmsgspec.DecodeErrorfor malformed TOML do not catch it, even though syntax failures are already wrapped asDecodeError.Keep UTF-8 conversion inside the parse-error boundary and wrap
UnicodeDecodeErrorusing the TOML wrapper's existing error convention. Buffer-type errors still propagate asTypeError. Regressions coverbytes,bytearray, andmemoryview, with valid non-ASCII TOML controls.Validation: all three malformed UTF-8 cases fail before the fix; the complete unit suite passes afterward (6553 passed, 116 existing skips). Ruff 0.17.0 lint and format checks pass for both changed files.