Add serialization and deserialization support for PHP 8.1 Enums.#173
Closed
seyfahni wants to merge 1 commit intomsgpack:masterfrom
Closed
Add serialization and deserialization support for PHP 8.1 Enums.#173seyfahni wants to merge 1 commit intomsgpack:masterfrom
seyfahni wants to merge 1 commit intomsgpack:masterfrom
Conversation
Contributor
|
This looks good, let's merge it and get a new release out, please. |
Contributor
|
cc @m6w6 |
Collaborator
|
There are already quite some PRs waiting and rotting, I'll try to prepare a v3 with all the things ASAP 👍 |
Collaborator
|
Merged as 93fe730 |
m6w6
added a commit
that referenced
this pull request
Aug 23, 2024
m6w6
added a commit
that referenced
this pull request
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for enum classes. They are serialized with a new serialize type
MSGPACK_SERIALIZE_TYPE_ENUM(dynamic id 6) and stored by using the enum class name as key and the enum case name as value.For example the serialized message pack blob from the added test (generated by
msgpack-inspect):Fixes issue #171.
This is incompatible with enums serialized before this change as they have been serialized as normal classes and thus did not set a numeric serialize type but the class name instead. Thus, old data will continue to fail deserialization in the same way if it does contain a serialized enum.