Skip to content

Add PHP 7.2 to the Travis CI matrix#129

Closed
sodabrew wants to merge 2 commits intomsgpack:masterfrom
sodabrew:php-7.2
Closed

Add PHP 7.2 to the Travis CI matrix#129
sodabrew wants to merge 2 commits intomsgpack:masterfrom
sodabrew:php-7.2

Conversation

@sodabrew
Copy link
Contributor

This PR will get PHP 7.1 and 7.2 fully tested. Then the PHP 7.3 PR #124 can be a bunch smaller and focus only on the recursion changes there.

@sodabrew
Copy link
Contributor Author

@laruence @Sean-Der are you available begin a train to get to PHP 7.3? There will be a number of PRs on the way from myself and @remicollet

@sodabrew
Copy link
Contributor Author

Hi! Is anybody available to support getting this module ready for the PHP 7.3 release?

@Jan-E
Copy link
Contributor

Jan-E commented Oct 30, 2018

Hi! Is anybody available to support getting this module ready for the PHP 7.3 release?

Try @remicollet
See #124

@andypost
Copy link
Contributor

FYI on aarch64 one test fails http://build.alpinelinux.org/buildlogs/build-edge-aarch64/community/php7-pecl-msgpack/php7-pecl-msgpack-2.0.3-r1.log

FAILED TEST SUMMARY
---------------------------------------------------------------------
Profiling perf test. [tests/035.phpt]
=====================================================================

@m6w6 m6w6 closed this Dec 18, 2019
@sodabrew
Copy link
Contributor Author

Thank you @m6w6! You've been on a tear recently! Really appreciate your work sprucing up this module. I'll be sure to update my test suite in php-memcached to use the latest msgpack-php, I hope you'll tag all this great work into a formal release version soon.

@sodabrew sodabrew deleted the php-7.2 branch December 18, 2019 12:31
@m6w6
Copy link
Collaborator

m6w6 commented Dec 18, 2019

Yes, I'm working on a new release.

And sorry, it looks like this PR could have been merged actually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants