Closed
Conversation
- disable bin2hex - it's dumping internal memory? - -0.0 is -0.0 in my platform
Current coverage is 86.29% (diff: 100%)@@ master #109 diff @@
==========================================
Files 8 8
Lines 1249 1233 -16
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1085 1064 -21
- Misses 164 169 +5
Partials 0 0
|
glensc
added a commit
to pld-linux/php-pecl-msgpack
that referenced
this pull request
Nov 22, 2016
This was referenced Dec 2, 2016
Contributor
|
#129 just skips this tests |
Collaborator
|
I merged #129, but this might have been the better fix. NaN has a myriad of possible binary representations, so please submit a new PR if you want this issue to be fixed in a better way. Thanks, and sorry for the hassle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed bin2hex because it's seems to be dependent on php platform (version, os, architecture) and it's seems to be dumping php internal memory not the actual object, tests in this repo should test msgpack not bin2hex() implementation.
this seems also php platform specific?