Repository navigation
[bug] decode throws RangeError on empty Uint8Array #198
Description
decode() throws RangeError on empty Uint8Array
steps to reproduce
const { decode } = require("@msgpack/msgpack");
decode(new Uint8Array());expected result
hmm hard to tell, maybe null or undefined.
decode(encode());returns null
actual result
Uncaught RangeError: Offset is outside the bounds of the DataView
at DataView.getUint8 (<anonymous>)
at Decoder.readU8 (/home/kuba/tmp_/node_modules/@msgpack/msgpack/dist/Decoder.js:532:33)
at Decoder.readHeadByte (/home/kuba/tmp_/node_modules/@msgpack/msgpack/dist/Decoder.js:425:34)
at Decoder.doDecodeSync (/home/kuba/tmp_/node_modules/@msgpack/msgpack/dist/Decoder.js:169:35)
at Decoder.decode (/home/kuba/tmp_/node_modules/@msgpack/msgpack/dist/Decoder.js:89:29)
at decode (/home/kuba/tmp_/node_modules/@msgpack/msgpack/dist/decode.js:14:20)
Activity
mrl5 commentedon Jan 19, 2022
workaround is to check if
length > 0and thendecode()gfx commentedon May 1, 2022
This is an expected behavior, as
JSON.parse("")raises a SyntaxError.I've clarified the behavior in #209 by adding test cases to make sure this behavior.
Handle edge case where message has length zero