Skip to content

internal: Remove dead code in MessagePacker. #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 1 commit into from
Jan 9, 2024
Merged

internal: Remove dead code in MessagePacker. #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions msgpack-core/src/main/java/org/msgpack/core/MessagePacker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,10 +774,6 @@ else if (s.length() < (1 << 16)) {
position += written;
}
else {
if (written >= (1L << 32)) { // this check does nothing because (1L << 32) is larger than Integer.MAX_VALUE
// this must not happen because s.length() is less than 2^16 and (2^16) * UTF_8_MAX_CHAR_SIZE is less than 2^32
throw new IllegalArgumentException("Unexpected UTF-8 encoder state");
}
// move 2 bytes backward to expand 3-byte header region to 5 bytes
buffer.putMessageBuffer(position + 5, buffer, position + 3, written);
// write 3-byte header header
Expand Down