Skip to content

Conversation

@christian-sahlmann
Copy link

org.msgpack.template.builder.JavassistTemplateBuilder$JavassistTemplate

#57

org.msgpack.template.builder.JavassistTemplateBuilder$JavassistTemplate

msgpack#57
@muga
Copy link
Member

muga commented Dec 10, 2013

Thank you for your pull request! (And sorry for the late reply..) I will check it:-)

@muga
Copy link
Member

muga commented Dec 18, 2013

Sorry for late reply. I reviewed your patch. It seems that It's good to me:-)

Do you have how to test the behavior of template building (class loading). I'm always struggling to check it. If you have any good idea, please let me know or make the new pull request. It would be appreciated.

@christian-sahlmann
Copy link
Author

Sorry, I have no idea how to test template building.
Anyway, is there something preventing this from being merged? It would be nice if I could use the official version of msgpack-java again.

@komamitsu
Copy link
Member

@muga Can you merge this commits if there is no concern?

@muga
Copy link
Member

muga commented Apr 20, 2014

@komamitsu I check now.

@muga muga merged commit e92cded into msgpack:master Apr 20, 2014
@muga
Copy link
Member

muga commented Apr 20, 2014

@Cbuehler Thank you for your request. I changed msgpack-java:master branch.

@komamitsu Cloud you release new version of msgpack-java when you can?

@komamitsu
Copy link
Member

@Cbuehler @muga I just released v0.6.11 to Sonatype. The new version is going to be available in a couple of hours.

@oza
Copy link
Member

oza commented Apr 21, 2014

@Cbuehler, @muga and @komamitsu, good job!

@christian-sahlmann
Copy link
Author

Great, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants