Add ByteBuffer input support again - #377
Closed
miniway wants to merge 1 commit into
Closed
Conversation
|
|
||
| public ByteBufferInput(ByteBuffer input) | ||
| { | ||
| this.input = checkNotNull(input, "input ByteBuffer is null"); |
Member
There was a problem hiding this comment.
I think it is better to call slice() as following to avoid this unexpected scenario:
- An user creates a new ByteBuffer and fill some data there
- The user creates a new
ByteBufferInputwith the ByteBuffer - the user changes position of the ByteBuffer! That might be by another thread.
- ByteBufferInput is affected the change of position, unexpectedly
this.input = checkNotNull(input, "input ByteBuffer is null").slice();
Member
|
sure. will do |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.