Skip to content

Support method-chain syntax to create packer and unpacker with immutable config #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xerial merged 4 commits into from
Jan 7, 2016
Merged

Support method-chain syntax to create packer and unpacker with immutable config #325

xerial merged 4 commits into from
Jan 7, 2016

Conversation

@frsyuki
Copy link
Member

@frsyuki frsyuki commented Jan 6, 2016

  • This change allows applications to use method-chain syntax to create packer and unpacker with config. For example,
MessageUnpacker unpacker = new UnpackerConfig()
    .withStringDecoderBufferSize(16 * 1024)
    .withActionOnMalformedString(CodingErrorAction.REPORT)
    .withActionOnUnmappableString(CodingErrorAction.REPORT)
    .newUnpacker(packedData);
  • This change makes {Packer,Unpacker}Config immutable. This makes it safe to share a config object.
  • This change makes buffer size of InputStreamBufferInput, OutputStreamBufferOutput, and ChannelBuffer{Input,Output} configurable. Configurable buffer size is better because it is trade-off of performance and memory consumption.

This was referenced Jan 6, 2016
Closed
Closed
xerial
xerial reviewed Jan 6, 2016
View reviewed changes
msgpack-core/src/main/java/org/msgpack/core/MessagePack.java
Copy link
Member

@xerial xerial Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test code to check the equality of config objects

Copy link
Member Author

@frsyuki frsyuki Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

xerial added a commit that referenced this pull request Jan 7, 2016
@xerial
Merge pull request #325 from msgpack/immutable-config
71a27f5 
Support method-chain syntax to create packer and unpacker with immutable config
@xerial xerial merged commit 71a27f5 into develop Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frsyuki @xerial