Skip to content

Support method-chain syntax to create packer and unpacker with config #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frsyuki wants to merge 1 commit into from
Closed

Support method-chain syntax to create packer and unpacker with config #322

frsyuki wants to merge 1 commit into from

Conversation

@frsyuki
Copy link
Member

@frsyuki frsyuki commented Jan 5, 2016

This change allows applications to use method-chain syntax to create packer and unpacker with config. For example,

MessageUnpacker unpacker = new UnpackerConfig()
    .setStringDecoderBufferSize(16 * 1024)
    .setActionOnMalformedString(CodingErrorAction.REPORT)
    .setActionOnUnmappableString(CodingErrorAction.REPORT)
    .newUnpacker(packedData);

instead of

UnpackerConfig unpackerConfig = new UnpackerConfig();
unpackerConfig.stringDecoderBufferSize = 16 * 1024;
unpackerConfig.actionOnMalformedString = CodingErrorAction.REPORT;
unpackerConfig.actionOnUnmappableString = CodingErrorAction.REPORT;
MessageUnpacker unpacker = unpackerConfig.newUnpacker(packedData);

@frsyuki frsyuki force-pushed the config-method-chain branch from 11aff28 to 5039f16 Compare January 5, 2016 22:01
@frsyuki frsyuki mentioned this pull request Jan 5, 2016
Closed
@frsyuki
Copy link
Member Author

frsyuki commented Jan 6, 2016

This pull-request is obsoleted by #325.

@frsyuki frsyuki closed this Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frsyuki