Make constructors protected to ensure the single entry point #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes constructors of MessagePacker and MessageUnpacker protected so that all users use factory methods of MessagePack interface. This removes duplication of API and make it easy to understand.
Member
Author
Member
Author
|
And I think, usually, such entry points are called Factory rather than Config. How do you think about using |
frsyuki
changed the title
Member
|
@frsyuki I talked with @komamitsu about class naming and reached to the conclusion that Using xxxFactory both for MessagePacker/Unpacker and Jackson binding is confusing. And I also agree that Config does not usually have a factory method. How about providing the following method so that user can notice config object is necessary to configure packer and unpacker? |
xerial
added a commit
that referenced
this pull request
Jan 6, 2016
Make constructors protected to ensure the single entry point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes constructors of MessagePacker and MessageUnpacker protected so
that all users use factory methods of MessagePack interface. This
removes duplication of API and make it easy to understand.