Rewrite LinkedBufferInput.java for Android - #18
Merged
Conversation
muga
added a commit
that referenced
this pull request
Jan 19, 2013
replaced method calls of LinkedList#peek{First,Last}() into LinkedList#get{First,Last}() within LinkedBufferInput class. the change is for Android
Member
|
Sorry for the delay... Thank you for your request!! I merged your patch. please check it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are interested in the Android version of Msgpack in the future,
please consider to rewrite LinkedBufferInput.java for Android.
There are some LinkedList#peekFirst() and LinkedList#peekLast() in LinkedBufferInput.java,
but they have been available since recent Android version(above Android 2.3).
So, please replace them to approximate equivalent methods LinkedList#getFirst() and LinkedList#getLast().
--Japanese--
もし将来的にAndroidへのMsgpackの移植をお考えなら、LinkedBufferInput.javaの書き換えをご一考ください。
LinkedList#peekFirst()とLinkedList#peekLast()はAndroid2.3以上でのみフレームワークに存在しており、
それ以下のバージョンのAndroidではクラッシュします。
これらはLinkedList#getFirst()とLinkedList#getLast()でほぼ等価な書き換えができます。(こちらはAndroid1.0以上でサポートされています)