V07 add jackson dataformat #146
Conversation
There was a problem hiding this comment.
You can add name property here to specify jar name (e.g., jackson-databind-msgpack)
There was a problem hiding this comment.
MessagePackFactory is already used in msgpack-core. Can you rename it?
There was a problem hiding this comment.
Hmm. Jackson-dataformat-xxxx uses a naming convention (Data format name)Factory such as SmileFactory, CsvFactory, YAMLFactory, XmlFactory and AvroFactory. So I can't come up with a better name than MessagePackFactory. Also, I think having the same class names isn't an import issue because ordinary developers don't need to consider it other than developers of jackson-dataformat-msgpack (off course, we can use the correct class with each package name).
There was a problem hiding this comment.
But in the msgpack-jackson/README.md, you mentioned
only you need to do is to instantiate MessagePackFactory
https://github.com/msgpack/msgpack-java/pull/146/files#diff-c1644750de4c3267355de3f00a0f6f05R20
It's already ambiguous.
There was a problem hiding this comment.
Removed core.MessagePackerFactory, and packer/unpacker can be instantiated from MessagePack class, so it's okay to leave jackson/MessagePackFactory class name unchanged.
README.md
Outdated
There was a problem hiding this comment.
Please explain what is jackson-databind. For example,
You can use jackson-databind to serialize/deserialize Java objects in MessagePack format. For details, see msgpack-jackson/README.md
|
package name |
… to avoid the name conflicts with jackson.MessagePackFactory
|
To avoid the name conflict of MessagePackFactory , I migrated the functionality of core.MessagePackFactory to MessagePack class. |
Good point. I'll change it. |
|
@xerial I made the package name shorter. |
|
@komamitsu If there is a possibility to add some |
|
@xerial I think it's possible we extend jackson core library as |
…ck-java into v07-add-jackson-dataformat
Signed-off-by: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>
|
Looks good to me. Merging. |
See #145