Optimize unpackBinary #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fixed some errors
Member
There was a problem hiding this comment.
We need to check offset + length <= arr.length?
Member
Author
There was a problem hiding this comment.
Correct. I will fix this statement.
Member
There was a problem hiding this comment.
How about checking here if the sum of offset + length doesn't exceed size?
Member
Author
There was a problem hiding this comment.
OK. If that test fails this code should throw IllegalArgumentException.
Member
|
👍 |
Member
There was a problem hiding this comment.
I think instanceof ByteArrayInputStream is not safe because in could be an instance of extended type of ByteArrayInputStream which overrides read(byte[]) method.
This is safe: ByteArrayInputStream.class.equals(in.getClass())
Member
Author
There was a problem hiding this comment.
That's true. We should compare the exact class type.
…fferBE.slice() to return big-endian buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized
unpackBinaryby reducing the memory copy inMessageBufferInputimplementations.The other changes are as follows:
A performance report is in #103.