proposed fix for https://github.com/msaccess-vcs-integration/msaccess-vcs-integration/issues/105 #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecon5
pushed a commit
to hecon5/msaccess-vcs-integration
that referenced
this pull request
Jan 14, 2021
These will be used to check for changes in VBA code and database objects. (Especially in cases where find/replace operations in VBA code do not affect the modified dates of the parent objects.) See msaccess-vcs-integration#106
hecon5
pushed a commit
to hecon5/msaccess-vcs-integration
that referenced
this pull request
Jan 14, 2021
Checking VBA hash to look for changes that may be saved independent of the object's modified date. (Work in progress) See msaccess-vcs-integration#106
hecon5
reviewed
Feb 17, 2021
hecon5
left a comment
hecon5
left a comment
There was a problem hiding this comment.
Thos looks good. Note that the addin version of this actually does it this way, too.
Before I approve this, perhaps you'd consider making this an option in the vcs.cfg? That way, users won't have their files unexpectedly moved on them (or duplicated).
Also, you may consider using the addin version, located at @joyfullservice https://github.com/joyfullservice/msaccess-vcs-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepending Application.CurrentProject.Name to "source" folder name