-
Notifications
You must be signed in to change notification settings - Fork 849
mruby-regexp: move the backtracking stack off the C stack #7307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c60599
mruby-regexp: back the backtracking engine's forks with a heap stack
takumin 360c616
mruby-regexp: log a capture's write instead of recursing over it
takumin 3af6379
mruby-regexp: log where an iteration began instead of recursing over it
takumin 421cadd
mruby-regexp: cut an atomic group by truncating the choice point stack
takumin b0ab075
mruby-regexp: cut a lookaround by truncating the choice point stack
takumin c51829e
mruby-regexp: drop what the frame-per-fork engine left behind
takumin f531406
mruby-regexp: log a write only where there is something to take back
takumin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Decide the compatibility policy for
Regexp::RECURSION_LIMIT.The PR removes the Ruby-visible
Regexp::RECURSION_LIMITconstant. Existing callers will raiseNameErrorafter upgrade. Keep a deprecated compatibility alias, or explicitly make this a documented breaking API change before merge.🧰 Tools
🪛 LanguageTool
[style] ~353-~353: ‘in answer to’ might be wordy. Consider a shorter alternative.
Context: ...ere turning
MRB_REGEXP_STACK_LIMITup in answer to an allocator that had nothing left woul...(EN_WORDINESS_PREMIUM_IN_ANSWER_TO)
🤖 Prompt for AI Agents