Skip to content

mruby-regexp: give the pattern its buffers before the compile starts #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz merged 3 commits into from
Aug 17, 2026
Merged

mruby-regexp: give the pattern its buffers before the compile starts #7232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b99c41e
mruby-regexp: take `mark_empty_loops()` scratch from one block
takumin Aug 17, 2026
1a26736
mruby-regexp: refuse a second `Regexp#initialize`
takumin Aug 17, 2026
8bb526e
mruby-regexp: give the pattern its buffers before the compile starts
takumin Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions mrbgems/mruby-regexp/include/re_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,15 @@ typedef struct {
#define RE_LIST_CAPA(code_len, depth) \
((int)(code_len) * (int)(RE_PASS_SPAN(depth) + 1) + 16)

/* Compile a pattern string into bytecode */
mrb_regexp_pattern* mrb_re_compile(mrb_state *mrb, const char *pattern, mrb_int len, uint32_t flags);
/* Compile a pattern string into `pat`, which the caller passes zero filled
and keeps reachable from a GC object for the whole call. Every buffer the
compile allocates hangs off `pat` from the moment it is allocated, so a
compile that raises, over a bad pattern or a refused allocation, leaves
them to mrb_re_free() rather than to the frame the longjmp abandons: the
zero fill is what lets mrb_re_free() read a pattern that got that far.
`pat->code_len` is written last and stays zero until the pattern is
complete. */
void mrb_re_compile(mrb_state *mrb, mrb_regexp_pattern *pat, const char *pattern, mrb_int len, uint32_t flags);

/* Free a compiled pattern */
void mrb_re_free(mrb_state *mrb, mrb_regexp_pattern *pat);
Expand Down
Loading
Loading