Skip to content

string.c: answer an ASCII-case build from the header's fallback #7222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz merged 1 commit into from
Aug 17, 2026
Merged

string.c: answer an ASCII-case build from the header's fallback #7222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/mruby/internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ enum mrb_case_mode {
which is what every build without the tables answers to every string.
`swapcase` lives in mruby-string-ext and reaches the tables through this, so
they are asked about in one place. */
#ifdef MRB_UTF8_STRING
#if defined(MRB_UTF8_STRING) && !defined(MRB_USE_ASCII_CASE)
int mrb_str_case_convert_unicode(mrb_state *mrb, mrb_value str, enum mrb_case_mode mode);
#else
#define mrb_str_case_convert_unicode(mrb, str, mode) (-1)
Expand Down
18 changes: 1 addition & 17 deletions src/string.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2248,23 +2248,7 @@ mrb_str_case_convert_unicode(mrb_state *mrb, mrb_value str, enum mrb_case_mode m
return str_case_convert_utf8(mrb, str, mode) ? 1 : 0;
}

#elif defined(MRB_UTF8_STRING)

/* The walk above is what a build asking for ASCII case gives up, and this is
where it says so: every caller of it converts the ASCII of a string in a
loop of its own and reaches for the walk only where the string holds more.
Answering that there was nothing to walk sends each of them back to that
loop, which is the conversion such a build asked for. */
int
mrb_str_case_convert_unicode(mrb_state *mrb, mrb_value str, enum mrb_case_mode mode)
{
(void)mrb;
(void)str;
(void)mode;
return -1;
}

#endif /* MRB_UTF8_STRING */
#endif /* MRB_UTF8_STRING && !MRB_USE_ASCII_CASE */

/* 15.2.10.5.8 */
/*
Expand Down
Loading