Skip to content

mruby-compiler: report a failed irep round trip in mrb_generate_code() #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz merged 1 commit into from
Aug 16, 2026
Merged

mruby-compiler: report a failed irep round trip in mrb_generate_code() #7204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions mrbgems/mruby-compiler/src/mruby_compat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,24 @@ mrb_parse_string(mrb_state *mrb, const char *s, mrb_ccontext *c)
return mrb_parse_nstring(mrb, s, strlen(s), c);
}

/* The dump and reload below is the one compiler-side failure codegen_error()
does not cover, and it leaves nothing on stderr on its own. Report it
through the same `quiet_errors` gate, so a caller that captures errors
(eval) still sees only the exception mrb_load_exec() raises. */
static void
report_roundtrip_error(mrc_ccontext *mc, const char *message)
{
#ifndef MRB_NO_STDIO
if (mc->quiet_errors) return;
if (mc->filename) {
fprintf(stderr, "%s: %s\n", mc->filename, message);
}
else {
fprintf(stderr, "%s\n", message);
}
#endif
}

MRB_API struct RProc*
mrb_generate_code(mrb_state *mrb, struct mrb_parser_state *p)
{
Expand All @@ -425,11 +443,13 @@ mrb_generate_code(mrb_state *mrb, struct mrb_parser_state *p)
mc = (mrc_ccontext*)p->ylval;
irep = (mrc_irep*)p->tree;
if (mrc_dump_irep(mc, irep, flags, &bin, &bin_size) != MRC_COMPAT_DUMP_OK) {
report_roundtrip_error(mc, "irep dump error");
return NULL;
}
mir = mrb_read_irep_buf(mrb, bin, bin_size);
mrc_free(mc, bin);
if (!mir) {
report_roundtrip_error(mc, "irep load error");
return NULL;
}
proc = mrb_proc_new(mrb, mir);
Expand Down
Loading