Skip to content

string.c: follow an ASCII run only as far as the index asks #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz merged 1 commit into from
Aug 15, 2026
Merged

string.c: follow an ASCII run only as far as the index asks #7185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/string.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,16 +740,14 @@ mrb_str_char_to_byte(mrb_state *mrb, mrb_value str, mrb_int off, mrb_int idx)

while (p<e && i<idx) {
if ((*p & 0x80) == 0) {
const char *np = search_nonascii(p, e);
ptrdiff_t alen = np - p;
if (idx < i+alen) {
p += idx-i;
i=idx;
}
else {
p = np;
i += alen;
}
/* Every ASCII byte stands for a character of its own, so the run only
has to be followed as far as the index asks for. Reading to the end of
the string instead makes finding the character just past the head cost
what finding the last one does. */
const char *lim = (e - p) > (idx - i) ? p + (idx - i) : e;
const char *np = search_nonascii(p, lim);
i += np - p;
p = np;
}
else {
p += mrb_utf8len(p, e);
Expand Down
Loading