Skip to content

mruby-sprintf: set the result's length through RSTR_SET_LEN() #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz merged 1 commit into from
Aug 14, 2026
Merged

mruby-sprintf: set the result's length through RSTR_SET_LEN() #7174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions mrbgems/mruby-sprintf/src/sprintf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,15 +618,9 @@ mrb_str_format(mrb_state *mrb, mrb_int argc, const mrb_value *argv, mrb_value fm
mark_written_bytes(result, str);
len = RSTRING_LEN(str);

/* Update result string length for embedded strings */
if (RSTRING(result)->flags & MRB_STR_EMBED) {
mrb_int tmp_n = len;
RSTRING(result)->flags &= ~MRB_STR_EMBED_LEN_MASK;
RSTRING(result)->flags |= tmp_n << MRB_STR_EMBED_LEN_SHIFT;
}
else {
RSTRING(result)->as.heap.len = blen;
}
/* Keep the result's length at what has been written into it, which
CHECK() leaves at the size of the whole buffer. */
RSTR_SET_LEN(mrb_str_ptr(result), blen);

/* Handle precision and width formatting */
if (flags&(FPREC|FWIDTH)) {
Expand Down
Loading