mruby-encoding: drop the unused utf8_islead macro - #7095
Merged
Conversation
`str_valid_enc_p` defines `utf8_islead` at its head but never expands it. The macro has been dead since the gem was added in 74bdae9: the function asks `mrb_utf8len` for the length of each character and rejects a stray byte with the `len == 1 && (*p & 0x80)` test, so it never inspects a continuation byte on its own. `src/string.c` defines a macro of the same name and still uses it. This change touches only the unused copy in the gem.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the unused Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mrbgems/mruby-encoding/src/encoding.cdefinesutf8_isleadat the head ofstr_valid_enc_p, but the function never expands it. The macro has been deadsince the gem was added in 74bdae9 (
mruby-encoding: add Poorman's Encoding gem):str_valid_enc_pasksmrb_utf8lenfor the length of each characterand rejects a stray byte with the
len == 1 && (*p & 0x80)test, so it neverinspects a continuation byte on its own.
src/string.ccarries its own definition of the same name and keeps using it,as does
mirb_buffer.c. This change touches only the unused copy in the gem.No behavior change.
rakebuilds clean.Summary by CodeRabbit