style/performance fixes - #7086
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
📝 WalkthroughWalkthroughThe change replaces Ruby type-predicate calls with ChangesCore Ruby library normalization
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merged, thank you. Both halves are changes I want, and the second one is a convention I wrote into What I checked before merging, since a sweep across nineteen files is the kind where a single bad substitution hides easily:
One request for next time, and it is about the shape rather than the content: please split a sweep like this into one pull request per kind of change. The reason is collision surface rather than review effort. This landed alongside a run of unrelated work in Nothing to change here, and I would rather have the sweep than not have it. Thank you for doing the unglamorous half of a convention. |
the code under
$repo/mrblib/has been changed to useyieldinstead of&.calldue to the
OP_BLKCALLoptimizationsimilarly, checks of the form
var.{is_a?, kind_of?}(Class)have been changed intoClass === var(aside from test, and prism source)Summary by CodeRabbit
Refactor
Bug Fixes