Skip to content

Fix build error with MRB_ARY_NO_EMBED #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dearblue wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build error with MRB_ARY_NO_EMBED #6712

dearblue wants to merge 2 commits into from
+15 −11

Conversation

@dearblue
Copy link
Contributor

@dearblue dearblue commented Jan 29, 2026

No description provided.

@dearblue
Replace struct RArray::as.ary with ARY_EMBED_PTR()
dff456f 
This prevents compilation errors when `MRB_ARY_NO_EMBED` is defined.

However, since `ARY_EMBED_PTR()` previously returned the integer value `0`, it has been modified to explicitly return a NULL pointer to `mrb_value`.
@dearblue
Introduce RARRAY_GETMEM() and ARY_GETMEM()
d8c7bcc 
The names are based on CRuby's `RSTRING_GETMEM()`.
@dearblue dearblue requested a review from matz as a code owner January 29, 2026 13:41
@github-actions github-actions bot added the core label Jan 29, 2026
@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Hello @dearblue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build error that arises when MRB_ARY_NO_EMBED is defined, by enhancing the robustness and consistency of array memory access. It introduces a new macro for a unified approach to obtaining array pointers and lengths, and refactors existing code to leverage this new abstraction. These changes improve type safety and streamline array handling across the codebase, particularly in configurations where array embedding is disabled.

Highlights

  • Unified Array Memory Access: Introduced a new macro, ARY_GETMEM, in include/mruby/array.h to provide a consistent and unified way to retrieve both the pointer and length of an array, abstracting away the distinction between embedded and heap-allocated arrays.
  • Type Safety Improvement: Modified the ARY_EMBED_PTR macro to explicitly cast NULL to (mrb_value*)NULL when MRB_ARY_NO_EMBED is defined, enhancing type safety and preventing potential build errors related to implicit type conversions.
  • Code Refactoring in VM: Refactored array access logic within src/vm.c to utilize the new ARY_GETMEM macro, replacing previous manual if-else checks for embedded vs. heap arrays. Additionally, updated direct embedded array element access to use the ARY_EMBED_PTR macro for consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 29, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a build error when MRB_ARY_NO_EMBED is defined by introducing macros to abstract away direct access to array internals, which is a good approach. The changes are correct and improve the code's robustness. I have one suggestion to further improve consistency by using the new macro in another location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matz matz Awaiting requested review from matz matz is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dearblue