Skip to content

Fix out of bounds read and write in IO.select #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz merged 3 commits into from
Jan 27, 2026
+13 −0
Merged

Fix out of bounds read and write in IO.select #6711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4483171
Fix out of bounds read and write in IO.select
Asmod4n Jan 25, 2026
8769f37
Improve error handling for file descriptor range
Asmod4n Jan 25, 2026
c836b09
Add error handling for fdset size limit
Asmod4n Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mrbgems/hal-posix-io/src/io_hal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,10 @@ void
mrb_hal_io_fdset_set(mrb_state *mrb, int fd, mrb_io_fdset *fdset)
{
(void)mrb;
if (fd < 0 || fd >= FD_SETSIZE) {
mrb_raise(mrb, E_ARGUMENT_ERROR, "fd is out of range");
return;
}
if (fdset) {
FD_SET(fd, &fdset->fds);
}
Expand All @@ -528,6 +532,10 @@ int
mrb_hal_io_fdset_isset(mrb_state *mrb, int fd, mrb_io_fdset *fdset)
{
(void)mrb;
if (fd < 0 || fd >= FD_SETSIZE) {
mrb_raise(mrb, E_ARGUMENT_ERROR, "fd is out of range");
return 0;
}
if (fdset) {
return FD_ISSET(fd, &fdset->fds);
}
Expand Down
5 changes: 5 additions & 0 deletions mrbgems/hal-win-io/src/io_hal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,11 @@ void
mrb_hal_io_fdset_set(mrb_state *mrb, int fd, mrb_io_fdset *fdset)
{
(void)mrb;
if (fdset->fds.fd_count >= FD_SETSIZE) {
mrb_raise(mrb, E_ARGUMENT_ERROR, "too many sockets for fd_set");
return;
}

if (fdset) {
FD_SET(fd, &fdset->fds);
}
Expand Down