Add the MRB_ENSURE() macro
#6709
Conversation
The purpose is to avoid using the `MRB_TT_CPTR` object. The reasons are as follows: - The `MRB_WORD_BOXING` setting involves object creation. - If object creation fails, the `ary_set_t` data leaks memory.
Summary of ChangesHello @dearblue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances mruby's C-level error handling by introducing a robust 'ensure'-like macro. This change streamlines resource management and exception safety in C extensions and core components, making the codebase more resilient and easier to maintain by centralizing cleanup logic. It also simplifies gem dependencies where error handling was previously managed. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new MRB_ENSURE macro to provide try...ensure-like functionality in C, which greatly simplifies resource management and exception handling. The new MRB_UNIQNAME helper macros are also added to support this. The implementation of MRB_ENSURE is clever and robust, using a for loop to guarantee execution of a cleanup block. The pull request also includes several refactorings across mruby-array-ext, mruby-bigint, and mruby-eval gems to adopt this new macro. These changes significantly improve code readability and maintainability by replacing manual cleanup and error re-raising logic with the concise MRB_ENSURE block. The removal of the mruby-error dependency from mruby-array-ext is also a correct consequence of this change. Overall, this is an excellent improvement to the codebase.
2 participants
No description provided.