mruby-bigint: compile as C++ when CXX exceptions enabled #6703
Conversation
Since commit 9471b13 added MRB_TRY/MRB_CATCH to bigint.c for exception-safe cleanup, the file includes <mruby/throw.h> which requires C++ compilation when MRB_USE_CXX_EXCEPTION is defined. Follow the same pattern as mruby-compiler to compile bigint sources as C++ when cxx_exception_enabled? is true. Fixes: mruby#6702
Summary of ChangesHello @khasinski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a compilation error within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the build configuration for the mruby-bigint gem. It ensures that the gem's C source files are compiled as C++ when C++ exceptions are enabled in the mruby build. This change is necessary due to the recent addition of exception handling macros (MRB_TRY/MRB_CATCH) that require C++ compilation when MRB_USE_CXX_EXCEPTION is defined. The implementation is clean, follows existing patterns in the mruby build system, and effectively resolves the compilation issue. The change is well-scoped and looks good to merge.
2 participants
Since commit 9471b13 added MRB_TRY/MRB_CATCH to bigint.c for exception-safe cleanup, the file includes <mruby/throw.h> which requires C++ compilation when MRB_USE_CXX_EXCEPTION is defined.
Follow the same pattern as mruby-compiler to compile bigint sources as C++ when cxx_exception_enabled? is true.
Fixes: #6702